Skip to content

Fix lint output and artifacts#1780

Merged
jmank88 merged 2 commits into
mainfrom
dx-2618/fix-lint
Jan 15, 2026
Merged

Fix lint output and artifacts#1780
jmank88 merged 2 commits into
mainfrom
dx-2618/fix-lint

Conversation

@chainchad
Copy link
Copy Markdown
Contributor

@chainchad chainchad commented Jan 15, 2026

Supersedes #1774

Comment thread .github/workflows/golangci_lint.yml Dismissed
@chainchad chainchad marked this pull request as ready for review January 15, 2026 16:29
@chainchad chainchad requested a review from a team as a code owner January 15, 2026 16:30
Copilot AI review requested due to automatic review settings January 15, 2026 16:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the golangci-lint integration by upgrading from version 3.0.0 to v4 and fixes issues with artifact naming and output file paths.

Changes:

  • Updated golangci-lint action version from ci-lint-go/3.0.0 to ci-lint-go/v4 in both the shell script and GitHub workflow
  • Added artifact name sanitization to handle module paths containing special characters
  • Fixed golangci-lint output file path to use the GitHub workspace directory

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
script/lint.sh Updated default golangci-lint version tag to v4
.github/workflows/golangci_lint.yml Added artifact name sanitization step and updated action version to v4 with corrected output paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 15, 2026

✅ API Diff Results - No breaking changes


📄 View full apidiff report

@jmank88 jmank88 added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit 7a06108 Jan 15, 2026
37 of 38 checks passed
@jmank88 jmank88 deleted the dx-2618/fix-lint branch January 15, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants